-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Fix broken link for Split Expenses
(Classic)
#60123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @NicMendonca |
@abdulrahuman5196 @NicMendonca One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
A preview of your ExpensifyHelp changes have been deployed to https://e32f664f.helpdot.pages.dev ⚡️ |
@NicMendonca @abdulrahuman5196 could you please complete the checklist to merge this? |
I don't think C+ is required here. @NicMendonca correct me if wrong |
You still need to complete the reviewer checklist @abdulrahuman5196, otherwise I can't merge. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Had to merge |
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.29-0 🚀
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.29-10 🚀
|
Explanation of Change
Context is here
Fixed Issues
$ #60115
Tests
QA Steps
https://help.expensify.com/articles/expensify-classic/expenses/Split-an-expense.html
https://help.expensify.com/articles/expensify-classic/expenses/Edit-expenses#split-an-expense
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop